Re: [PATCH 2/2 hurd] xkb: Fix delete key in graphical console

[Samuel Thibault]

Damien Zammit, le dim. 27 oct. 2024 09:38:08 +0000, a ecrit:
> Commenting out this block of code allows
> delete key to function without crashing pc_kbd driver.

Is the xkb_state_mod_names_are_active call not just missing the NULL
sentinel as documented in xkbcommon.h?

> ---
>  console-client/xkb/xkb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/console-client/xkb/xkb.c b/console-client/xkb/xkb.c
> index 31253f5c..08b875c9 100644
> --- a/console-client/xkb/xkb.c
> +++ b/console-client/xkb/xkb.c
> @@ -113,6 +113,8 @@ execute_action(keycode_t keycode)
>  {
>  
>    xkb_keysym_t keysym = xkb_state_key_get_one_sym (state, keycode);
> +
> +#if 0 // FIXME: scancode 0x6b appears on the stack in the wrong place when 
> delete is pressed
>    /* if CTRL+ALT+Delete is pressed notify the caller */
>    if (keysym == XKB_KEY_Delete &&
>        xkb_state_mod_names_are_active (state, XKB_STATE_MODS_EFFECTIVE, 
> XKB_STATE_MATCH_ALL, XKB_MOD_NAME_CTRL,
> @@ -121,6 +123,7 @@ execute_action(keycode_t keycode)
>        console_exit ();
>        return 1;
>      }
> +#endif
>  
>    if (xkb_state_mod_name_is_active (state, XKB_MOD_NAME_ALT, 
> XKB_STATE_MODS_EFFECTIVE) > 0)
>      {
> -- 
> 2.45.2