Re: [RFC PATCH] Adding RTC device (work in progress)

[Samuel Thibault]

Sergey Bugaev, le ven. 01 nov. 2024 15:13:26 +0300, a ecrit:
> On Fri, Nov 1, 2024 at 2:46 PM Zhaoming Luo <zhaoming1357@qq.com> wrote:
> > diff --git a/hurd/pioctl.defs b/hurd/pioctl.defs
> > new file mode 100644
> > index 00000000..36fa8d3f
> > --- /dev/null
> > +++ b/hurd/pioctl.defs
> > @@ -0,0 +1,34 @@
> > +/* Definitions for /dev/rtc ioctls */
> > +
> > +/* Ioctl group 'p'; the subsystem is derived from calculations in
> > +   hurd/ioctls.defs. */
> > +subsystem pioctl 140000;
> > +
> > +#include <hurd/ioctl_types.defs>
> > +
> > +import "rtc.h";
> 
> This would only work when the generated C file is built in the rtc/ of
> the Hurd source tree, right? Perhaps this should be <hurd/rtc/rtc.h>?
> 
> Do I understand it right that pioctl.defs *is* supposed to be
> installed onto the target machine (in some sort of hurd-dev package),
> as opposed to being a private implementation detail of the RTC server?

Other software might want to implement the rtc ioctls, so that should
rather be public, yes.

Samuel