Re: [PATCHv2 0/3] ada: Add GNU/Hurd x86_64 support

[Marc Poulhiès]

Samuel Thibault <samuel.thibault@gnu.org> writes:

> Hello,
>
> Marc Poulhiès, le lun. 04 nov. 2024 16:28:43 +0100, a ecrit:
>> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
>>
>> > I reworked the patch to factorize the bsd signal definitions.
>> > I have split off the system definitions because the priority range of
>> > GNU/Mach has diverged from the original BSD kernels.
>>
>> >  gcc/ada/ChangeLog                             |  17 ++
>>
>> The changes look good, I'll finish the review tomorrow.
>
> Thanks for the reviews!
>
>> But I can already point out that your 3 patches include changes to the
>> ChangeLog file, which should not be the case (it's automated from the
>> git log now).
>
> Ok.
>
> I don't have git commit access.
> Should I re-send the series without the ChangeLog changes?

Yes please!

I can take care of merging your changes when this is done, and also the
point below.

I've checked and you're not listed in the FSF copyright assignment for
GCC. Maybe you are contributing this through your employer? If not, then
you need to either:

- file the copyright assignment for GCC
- or use the DCO, see: https://gcc.gnu.org/dco.html

Marc