Re: [PATCH 4/5 gnumach] smp: Make sure BSP is cpu 0 when starting other cpus

[Samuel Thibault]

Applied, thanks!

Damien Zammit via Bug reports for the GNU Hurd, le mar. 10 déc. 2024 07:30:04 
+0000, a ecrit:
> This is basically a no-op but ensures we are doing smp
> bringup correctly.
> 
> ---
>  i386/i386/mp_desc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/i386/i386/mp_desc.c b/i386/i386/mp_desc.c
> index 7595eb1e..295fccc7 100644
> --- a/i386/i386/mp_desc.c
> +++ b/i386/i386/mp_desc.c
> @@ -323,7 +323,9 @@ start_other_cpus(void)
>       memcpy((void*) phystokv(apboot_addr), (void*) &apboot,
>              (uint32_t)&apbootend - (uint32_t)&apboot);
>  
> -     unsigned cpu;
> +     unsigned cpu = cpu_number_slow();
> +
> +     assert (cpu == 0);
>  
>       asm volatile ("cli");
>  
> -- 
> 2.45.2
> 
> 
> 

-- 
Samuel
<i8b4uUnderground> d-_-b
<BonyNoMore> how u make that inverted b?
<BonyNoMore> wait
<BonyNoMore> never mind