Re: [PATCH gnumach] acpi_parse_apic: Check CAPABLE bit field on lapic MADT flag

[Samuel Thibault]

Applied, thanks!

Damien Zammit via Bug reports for the GNU Hurd, le sam. 21 déc. 2024 02:39:48 
+0000, a ecrit:
> Previously, we were ignoring cpus that were not enabled
> but online-capable.
> ---
>  i386/i386at/acpi_parse_apic.c | 2 +-
>  i386/i386at/acpi_parse_apic.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/i386/i386at/acpi_parse_apic.c b/i386/i386at/acpi_parse_apic.c
> index 24470426..ae92ee2e 100644
> --- a/i386/i386at/acpi_parse_apic.c
> +++ b/i386/i386at/acpi_parse_apic.c
> @@ -376,7 +376,7 @@ static void
>  acpi_apic_add_lapic(struct acpi_apic_lapic *lapic_entry)
>  {
>      /* If cpu flag is correct */
> -    if (lapic_entry->flags & 0x1) {
> +    if (lapic_entry->flags & (ACPI_LAPIC_FLAG_ENABLED | 
> ACPI_LAPIC_FLAG_CAPABLE)) {
>          /* Add cpu to processors' list. */
>          apic_add_cpu(lapic_entry->apic_id);
>      }
> diff --git a/i386/i386at/acpi_parse_apic.h b/i386/i386at/acpi_parse_apic.h
> index 85e01170..df8d4bae 100644
> --- a/i386/i386at/acpi_parse_apic.h
> +++ b/i386/i386at/acpi_parse_apic.h
> @@ -149,6 +149,8 @@ struct acpi_apic_lapic {
>      uint32_t    flags;
>  } __attribute__((__packed__));
>  
> +#define ACPI_LAPIC_FLAG_ENABLED      (1 << 0)
> +#define ACPI_LAPIC_FLAG_CAPABLE      (1 << 1)
>  
>  /*
>   * I/O APIC Structure
> -- 
> 2.45.2
> 
> 
> 

-- 
Samuel
We are Pentium of Borg. Division is futile. You will be approximated.
(seen in someone's .signature)