Re: [RFC PATCH Hurd] Add a libstore library without libparted

[Samuel Thibault]

Zhaoming Luo, le sam. 11 janv. 2025 09:47:35 +0800, a ecrit:
> On Thu, Jan 09, 2025 at 02:09:01PM +0100, Samuel Thibault wrote:
> > Hello,
> > 
> > Zhaoming Luo, le jeu. 09 janv. 2025 20:58:22 +0800, a ecrit:
> > > The library can be compiled using the following command in the build/
> > > directory:
> > > ```
> > > make libstore-noparted
> > > ```
> > > 
> > > This file is the same as libstore/Makefile except a few modifications so
> > > it can use the source files from libstore/ and build a libstore with
> > > libparted module.
> > 
> > Thanks for working on it. AIUI the only needed modifications are in
> > store-types and libstore.so-LDLIBS?
> 
> We also need to modify `dir` and `libname` I think.

Yes, sure.

> > I'm thinking we can probably factorize this, by using something like:
> > 
> > # Use the source files from the libstore library
> > VPATH += $(top_srcdir)/libstore
> > 
> > USE_PARTED := 0
> > 
> > include ../libparted/Makefile
> 
> I think you mean `../libstore/Makefile`

Oops, sure :)

> > and in libparted/Makefile, set USE_PARTED ?= 1 and combine it with
> > $(and) like is done for HAVE_LIBZ etc.
> 
> I think you mean `libstore/Makefile`.

Ditto :)

Samuel