Re: [PATCH gnumach v1] [aarch64] make hwcaps_t a pointer to uint64_t

[Samuel Thibault]

Applied, thanks!

dnietoc@gmail.com, le jeu. 09 janv. 2025 22:40:55 +0000, a ecrit:
> From: Diego Nieto Cid <dnietoc@gmail.com>
> 
> Hi,
> 
> I went ahead and made a patch for the hwcaps_t type. I'm not sure
> if it is that simple. I figured the implementation of the RPC should
> be changed too, but couldn't find it in gnumach sources.
> 
> Also, I didn't test this at all. I guess I need to somehow cross
> compile and run it in qemu...
> 
> I hope this helps more than being a burden to review :)
> 
> -- >8 -- >8 -- >8 --
> 
>   * aarch64/include/mach/aarch64/mach_aarch64.defs: (hwcaps_t) make type an
>     array of uint64_t.
>   * aarch64/include/mach/aarch64/mach_aarch64_types.h (hwcaps_t) make type a
>     pointer to uint64_t
> ---
>  aarch64/include/mach/aarch64/mach_aarch64.defs    | 2 +-
>  aarch64/include/mach/aarch64/mach_aarch64_types.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/aarch64/include/mach/aarch64/mach_aarch64.defs 
> b/aarch64/include/mach/aarch64/mach_aarch64.defs
> index 0fe1eb62..da1e9498 100644
> --- a/aarch64/include/mach/aarch64/mach_aarch64.defs
> +++ b/aarch64/include/mach/aarch64/mach_aarch64.defs
> @@ -43,7 +43,7 @@ import <mach/machine/mach_aarch64_types.h>;
>   *   versions can add more items and more bits (HWCAP3_* and
>   *   so forth).
>   */
> -type hwcaps_t        =       array[*:16] of uint32_t;
> +type hwcaps_t        =       array[*:16] of uint64_t;
>  
>  routine aarch64_get_hwcaps(
>               host            : host_t;
> diff --git a/aarch64/include/mach/aarch64/mach_aarch64_types.h 
> b/aarch64/include/mach/aarch64/mach_aarch64_types.h
> index 98fd6c4b..efb9f897 100644
> --- a/aarch64/include/mach/aarch64/mach_aarch64_types.h
> +++ b/aarch64/include/mach/aarch64/mach_aarch64_types.h
> @@ -25,7 +25,7 @@
>  
>  #ifndef __ASSEMBLER__
>  #include <stdint.h>
> -typedef uint32_t *hwcaps_t;
> +typedef uint64_t *hwcaps_t;
>  #endif
>  
>  /* These definitions are meant to match those in
> -- 
> 2.47.1
> 
> 

-- 
Samuel
 Cliquez sur le lien qui suit dans ce mail...vous n'avez plus qu'a vous
 inscrire pour gagner de l'argent en restant connecte....et puis faites
 passer le message et vous gagnerez encore plus d'argent ...
 -+- AC in NPC : Neuneu a rencontré le Pere Noël -+-