Re: [PATCH 0/1] fix cp /dev/null file

[Samuel Thibault]

gfleury, le sam. 18 janv. 2025 13:10:20 +0200, a ecrit:
> This fixes a bug related to `cp /dev/null file`, where you would encounter an 
> error like:
> `skipping file /dev/null as it was replaced while being copied`.
> 
> I reduced the `st_blksize` to one page, as it is on GNU/Linux, and added a 
> persistent inode `st->st_rdev`.

We would first need to understand what is really happening.

Having a large blksize shouldn't be a problem, and it helps some tools
to tend to use a larger buffer. What line of code actually dislike this?

The rdev is usually set by translators to just 0. For streamio,
applications may want to expose a particular rdev, but for null, 0
should be just fine. What line of code actually wants something
different from 0?

Samuel