Re: [PATCH hurd v1] Add partial /proc/cpuinfo implementation

[Sergey Bugaev]

On Mon, Jan 27, 2025 at 12:18 AM Samuel Thibault
<samuel.thibault@gnu.org> wrote:
> > +  err = aarch64_get_hwcaps(mach_host_self(), &caps, &mdir, &revdir);
> > +  if (err)
> > +    goto out;
> > +
> > +  implementer = (mdir  & 0xff000000) >> 24;
> > +  variant = (mdir      & 0x00f00000) >> 20;
> > +  architecture = (mdir & 0x000f0000) >> 16;
> > +  part_num = (mdir     & 0x0000fff0) >> 4;
> > +  revision = (mdir     & 0x0000000f) >> 0;
>
> Better align mdir too to make it look nicer.

Speaking of which, it's midr (main identification register) and revidr
(revision identification register), not *dir.

> > +out:
> > +  flcose(m);
>
> You didn't try to compile it ;)

I suppose that's not easy for Diego to do, given the state of aarch64-gnu :)

Sergey