bug-hyperbole
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#46606: Enabling Hyperbole unbinds 'h' key in Gnus; toggling bindings


From: Robert Weiner
Subject: bug#46606: Enabling Hyperbole unbinds 'h' key in Gnus; toggling bindings twice unbinds 'h' globally
Date: Sun, 21 Feb 2021 13:03:25 -0500

This bug has been fixed in the latest Hyperbole git tip, commit #a831ef9e7.

Mats, please test and then close this bug.

-- Bob

On Wed, Feb 17, 2021 at 6:21 PM Bodertz <bodertz@gmail.com> wrote:
I use:  Editor:      GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
        Hyperbole:   7.1.3
        Sys Type:    x86_64-pc-linux-gnu
        OS Type:     gnu/linux
        Window Sys:  pgtk
        News Reader: Gnus v5.13

Steps to reproduce:

 1. (require 'hyperbole)

 2. {M-x gnus RET}
    - 'h' is unbound
    - should run describe-mode (found in gnus-group-mode-map)

3. {M-x hyperbole-toggle-bindings} while in Gnus
   - 'h' remains unbound

4. {M-x hyperbole-toggle-bindings} again while in Gnus
   - 'h' remains unbound

5. Switch to the *scratch* buffer: {C-x b *scratc C-q h* RET}
   - 'h' is now unbound here as well


I'm not sure what information I should be providing.
gnus-group-mode-map (and gnus-summary-mode-map) is long and confusing,
and I figure you can find it yourself easily, so I haven't included it
here.  I can if you want.

I have included a diff of gnus-summary-mode-map before and after
requiring hyperbole.  I use this instead of gnus-group-mode-map because
I first found the issue there; I don't use 'h' in the Group buffer.  In
gnus-summary-mode-map, 'h' should run gnus-summary-show-article.  As the
diff shows, requiring hyperboling removes gnus-summary-show-article (as
well as gnus-summary-article-map and gnus-summary-scroll-down).


------


diff -u --label \#\<buffer\ keymap\> --label \#\<buffer\ \*Help\*\> /tmp/buffer-content-g4KVJE /tmp/buffer-content-la1sHb
--- #<buffer keymap>
+++ #<buffer *Help*>
@@ -73,9 +73,9 @@
               (110 . gnus-summary-next-unread-subject)
               (16 . gnus-summary-prev-same-subject)
               (14 . gnus-summary-next-same-subject)
-              (13 . gnus-summary-scroll-down)
+              (13)
               (117 . gnus-summary-clear-mark-forward))
-             nil nil nil nil gnus-summary-next-page gnus-summary-tick-article-forward nil gnus-summary-mark-as-processable nil nil gnus-summary-execute-command nil nil nil gnus-cache-enter-article nil gnus-summary-best-unread-article negative-argument gnus-summary-first-unread-article gnus-summary-limit-map digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument nil nil gnus-summary-beginning-of-article gnus-summary-expand-window gnus-summary-end-of-article gnus-summary-mark-as-dormant nil gnus-summary-article-map gnus-summary-backend-map gnus-summary-cancel-article gnus-summary-mark-as-read-backward gnus-summary-mark-as-expirable gnus-summary-followup-with-original gnus-summary-goto-map gnus-summary-help-map gnus-summary-increase-score nil gnus-summary-mime-map gnus-summary-lower-score gnus-summary-mark-map gnus-summary-next-article gnus-summary-save-map gnus-summary-prev-article gnus-summary-exit-no-update gnus-summary-reply-with-original gnus-summary-send-map gnus-summary-thread-map gnus-summary-tick-article-backward gnus-summary-score-map gnus-summary-wash-map gnus-uu-extract-map gnus-summary-buffer-map gnus-summary-exit-map gnus-summary-prev-unseen-article nil gnus-summary-next-unseen-article gnus-summary-refer-parent-article nil nil gnus-summary-post-news gnus-article-view-part gnus-summary-catchup-and-exit gnus-summary-mark-as-read-forward gnus-summary-edit-article gnus-summary-followup gnus-summary-show-article gnus-summary-select-article-buffer nil gnus-summary-goto-article gnus-summary-kill-same-subject-and-select gnus-summary-goto-last-article gnus-summary-mail-other-window gnus-summary-next-unread-article gnus-summary-save-article gnus-summary-prev-unread-article gnus-summary-exit gnus-summary-reply gnus-summary-isearch-article gnus-summary-toggle-header gnus-summary-tick-article-forward nil gnus-summary-browse-url gnus-summary-limit-to-unread nil nil nil gnus-summary-pipe-output nil nil gnus-summary-prev-page]
+             nil nil nil nil gnus-summary-next-page gnus-summary-tick-article-forward nil gnus-summary-mark-as-processable nil nil gnus-summary-execute-command nil nil nil gnus-cache-enter-article nil gnus-summary-best-unread-article negative-argument gnus-summary-first-unread-article gnus-summary-limit-map digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument digit-argument nil nil gnus-summary-beginning-of-article gnus-summary-expand-window gnus-summary-end-of-article gnus-summary-mark-as-dormant nil t gnus-summary-backend-map gnus-summary-cancel-article gnus-summary-mark-as-read-backward gnus-summary-mark-as-expirable gnus-summary-followup-with-original gnus-summary-goto-map gnus-summary-help-map gnus-summary-increase-score nil gnus-summary-mime-map gnus-summary-lower-score gnus-summary-mark-map gnus-summary-next-article gnus-summary-save-map gnus-summary-prev-article gnus-summary-exit-no-update gnus-summary-reply-with-original gnus-summary-send-map gnus-summary-thread-map gnus-summary-tick-article-backward gnus-summary-score-map gnus-summary-wash-map gnus-uu-extract-map gnus-summary-buffer-map gnus-summary-exit-map gnus-summary-prev-unseen-article nil gnus-summary-next-unseen-article gnus-summary-refer-parent-article nil nil gnus-summary-post-news gnus-article-view-part gnus-summary-catchup-and-exit gnus-summary-mark-as-read-forward gnus-summary-edit-article gnus-summary-followup gnus-summary-show-article t nil gnus-summary-goto-article gnus-summary-kill-same-subject-and-select gnus-summary-goto-last-article gnus-summary-mail-other-window gnus-summary-next-unread-article gnus-summary-save-article gnus-summary-prev-unread-article gnus-summary-exit gnus-summary-reply gnus-summary-isearch-article gnus-summary-toggle-header gnus-summary-tick-article-forward nil gnus-summary-browse-url gnus-summary-limit-to-unread nil nil nil gnus-summary-pipe-output nil nil gnus-summary-prev-page]
        #^^[1 0
              #^^[2 0 #1# nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil]
              nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil]

Diff finished.  Wed Feb 17 14:51:28 2021



_______________________________________________
Bug-hyperbole mailing list
Bug-hyperbole@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-hyperbole

reply via email to

[Prev in Thread] Current Thread [Next in Thread]