[bug-inetutils] Ping6 bug - timing gone wild

[Michal Svoboda]

Hello,

Package: inetutils 1.5, program: ping6, symptom:

# ping6 ::1
PING ::1 (::1): 48 data bytes
56 bytes from localhost: icmp_seq=0 ttl=64 time=-504902579930790.188 ms
56 bytes from localhost: icmp_seq=1 ttl=64 time=-504902583956786.188 ms
...

I believe the bug is in incorrect pointer handling at print_echo() (see
patch below). Possibly the bug does not manifest itself on architectures
where sizeof(timeval) == sizeof(icmp6_hdr).

Regards,
Michal Svoboda

--- ping6.c~    2007-06-29 00:58:24.000000000 +0200
+++ ping6.c     2007-11-18 11:44:05.000000000 +0100
@@ -468,7 +468,7 @@
       struct timeval tv1, *tp;
 
       timing++;
-      tp = (struct timeval *) icmp6 + 1;
+      tp = (struct timeval *) (icmp6 + 1);
 
       /* Avoid unaligned data: */
       memcpy (&tv1, tp, sizeof (tv1));