|
From: | Simon Josefsson |
Subject: | Re: [bug-inetutils] telnet bug: will_wont_resp is not initialized |
Date: | Wed, 22 Aug 2012 13:50:56 +0200 |
User-agent: | Gnus/5.130006 (Ma Gnus v0.6) Emacs/23.3 (gnu/linux) |
Petr Malát <address@hidden> writes: > These variables are not static - they are shared between telnet.c and > utilities.c. Making them static was the first thing I tried :-) That makes sense now, thank you. Applied and pushed. /Simon > 2012/8/22 Simon Josefsson <address@hidden>: >> Petr Malát <address@hidden> writes: >> >>> -char options[256]; /* The combined options */ >>> -char do_dont_resp[256]; >>> -char will_wont_resp[256]; >>> +char options[256] = { 0 }; /* The combined options */ >>> +char do_dont_resp[256] = { 0 }; >>> +char will_wont_resp[256] = { 0 }; >> >> This seems weird and should be a no-op -- global static variables should >> be initialized to zero by the compiler. >> >> /Simon
[Prev in Thread] | Current Thread | [Next in Thread] |