Re: still many problems under OpenSolaris

[Ralf Wildenhues]

Hello Vadim,

* Vadim Zeitlin wrote on Thu, Feb 25, 2010 at 10:09:16PM CET:
> On Thu, 25 Feb 2010 21:57:59 +0100 Ralf Wildenhues wrote:
> RW> Yeah, the Libtool macros are fairly dumb in that they only detect Sun
> RW> C++ when it's called CC I think.
> 
>  Oh. And I thought I'd actually make its life simpler if I called them
> sun{cc,CC} as it would definitely know that I'm using Sun compilers then :-/

Yeah.  And actually we do detect them with that name correctly on
GNU/Linux, just not on Solaris.  Let's fix that.

> RW> I guess we could change the match (around line 3826 in current git) to
> RW>    CC* | sunCC*)
> 
>  I assume we're speaking about libltdl/m4/libtool.m4 file, right?

Yes, right.  Sorry about being so imprecise, I was tired when writing.

> And just
> to be certain: what do I need to re-do after modifying this file?

Running './bootstrap' in the Libtool source tree, 'make all install' in
the Libtool build tree, then rerunning autoreconf in your package to
pick up the changes.

>  BTW, it might make sense to recognize it under sunCC name under Linux too.
> I see the code (line 3769) to do it by running "CC -V" there but it
> shouldn't even needed if it's explicitly called sun{cc,CC} and especially
> under Linux it does make sense to use this name IMHO to make it clear that
> it's not the usual cc -> gcc link.

Yes.

I'm pushing this patch after testing it on i386-pc-solaris2.10 (gives
the same results as when using the names without 'sun' prefix).

Cheers, and thanks again,
Ralf

    Detect Sun compiler suite with 'sun'-prefixed names.
    
    * libltdl/m4/libtool.m4 (_LT_COMPILER_PIC, _LT_LANG_CXX_CONFIG)
    (_LT_SYS_HIDDEN_LIBDEPS) [solaris]: Accept compiler names sunCC,
    sunf77, sunf90, sunf95 in addition to CC, f77, f90, f95.
    * NEWS: Update.
    Report by Vadim Zeitlin.

diff --git a/NEWS b/NEWS
index 00ab5c1..ac5a40c 100644
--- a/NEWS
+++ b/NEWS
@@ -65,6 +65,7 @@ New in 2.2.8 2010-??-??: git version 2.2.7a, Libtool team:
     just as it is when linking libraries through the compiler driver.
   - Symbol versioning works with the GNU gold linker now.
   - Fixes for detection of shared library dependencies on MinGW systems.
+  - Fixed Sun compiler detection on Solaris with sunCC, sunf77 etc. names.
 
 * Miscellaneous changes:
 
diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
index f99e618..677505d 100644
--- a/libltdl/m4/libtool.m4
+++ b/libltdl/m4/libtool.m4
@@ -3823,7 +3823,7 @@ m4_if([$1], [CXX], [
        ;;
       solaris*)
        case $cc_basename in
-         CC*)
+         CC* | sunCC*)
            # Sun C++ 4.2, 5.x and Centerline C++
            _LT_TAGVAR(lt_prog_compiler_pic, $1)='-KPIC'
            _LT_TAGVAR(lt_prog_compiler_static, $1)='-Bstatic'
@@ -4107,7 +4107,7 @@ m4_if([$1], [CXX], [
       _LT_TAGVAR(lt_prog_compiler_pic, $1)='-KPIC'
       _LT_TAGVAR(lt_prog_compiler_static, $1)='-Bstatic'
       case $cc_basename in
-      f77* | f90* | f95*)
+      f77* | f90* | f95* | sunf77* | sunf90* | sunf95*)
        _LT_TAGVAR(lt_prog_compiler_wl, $1)='-Qoption ld ';;
       *)
        _LT_TAGVAR(lt_prog_compiler_wl, $1)='-Wl,';;
@@ -6255,7 +6255,7 @@ if test "$_lt_caught_CXX_error" != yes; then
 
       solaris*)
         case $cc_basename in
-          CC*)
+          CC* | sunCC*)
            # Sun C++ 4.2, 5.x and Centerline C++
             _LT_TAGVAR(archive_cmds_need_lc,$1)=yes
            _LT_TAGVAR(no_undefined_flag, $1)=' -zdefs'
@@ -6618,7 +6618,7 @@ linux*)
 
 solaris*)
   case $cc_basename in
-  CC*)
+  CC* | sunCC*)
     # The more standards-conforming stlport4 library is
     # incompatible with the Cstd library. Avoid specifying
     # it if it's in CXXFLAGS. Ignore libCrun as