Re: [bug-libunistring] ‘cdefs.h’ missing from the distribution

[Bruno Haible]

Hi Ludo,

> Libunistring fails to build on Hydra:
> 
> --8<---------------cut here---------------start------------->8---
> gcc -DHAVE_CONFIG_H -DNO_XMALLOC -I. -I..  -I. -I. -I.. -I.. 
> -DIN_LIBUNISTRING -DDEPENDS_ON_LIBICONV=1   -g -O2 -c striconveh.c
> In file included from striconveh.c:30:
> unistr.h:23:29: error: unistring/cdefs.h: No such file or directory
> make[2]: *** [config.h] Error 1
> --8<---------------cut here---------------end--------------->8---
> 
> (See, e.g., http://hydra.nixos.org/build/197472 .)
> 
> Apparently ‘cdefs.h’ is missing from the distribution.

The tarball that you use appears to take modified files from the git
repository but ignore new files added in the git repository.

- In http://hydra.nixos.org/build/197472/nixlog/1/raw: I added a file
  lib/unistring/cdefs.h, and included it from unistr.h. The error is
    unistr.h:23:29: error: unistring/cdefs.h: No such file or directory
  meaning that it used the updated lib/unistr.h.

- In http://hydra.nixos.org/build/200423/nixlog/1/raw: I renamed the file
  lib/unistring/cdefs.h to lib/unistring/cdefs.h.in and added a Makefile
  rule for creating lib/unistring/cdefs.h from lib/unistring/cdefs.h.in.
  The error is
    make[2]: *** No rule to make target `unistring/cdefs.in.h', needed by 
`unistring/cdefs.h'.  Stop.
  meaning that it used the updated lib/Makefile.am.

Are you by change a virtual CVS access to the git repository when producing
the tarball? It is known that some version of this CVS server has the problem
that "cvs update" misses freshly added files.

Bruno