Re: Issue 1104 in lilypond: Enhancement: 'offset for \underline markup function needed (and proposed)

[lilypond]

Comment #4 on issue 1104 by perpeduumimmobile: Enhancement: 'offset for  
\underline markup function needed (and proposed)
http://code.google.com/p/lilypond/issues/detail?id=1104

Hi, Kieren,


LGTM, but I'm not allowed to push, too.  I'm just trying to follow Graham's  
beg for reviewers...

A minor correction:
(* -1 offset) can be simplified to (- offset) in the (let*) clause for y.

I like your default value for offset, since in normalsize text, the  
underline does not cross the descenders of the font.  But I wonder whether  
both offset (linearly) and thickness (<= linearly) should be scaled with  
font-size, for a consistent look e.g. in the ((sub-)sub-)title fields?