Re: Thumb in fret-diagram

[Thomas Morley]

2015-05-04 8:43 GMT+02:00 pls <address@hidden>:
> This looks like a regression to me. See
>
> https://codereview.appspot.com/4176056/ (allow non numeric fingers (e.g. for
> thumb))
> http://lilypond.org/doc/v2.19/input/regression/dd/lily-caf6e8f6.ly (the “P”
> is not printed)
>
> hth
> patrick



Hi Patrick,

thanks for your findings.

This (for me formerly unknown feature) has gone with my patch for issue 2752
https://code.google.com/p/lilypond/issues/detail?id=2752

It was never documented and the regtest for _exactly_ this was _not_
triggered, as you can read there.

So the first time it came up
http://lilypond.1069038.n5.nabble.com/2-19-14-lost-ability-to-add-note-name-in-fret-board-td166644.html
I wrote:
"
I wouldn't call it a regression, because adding and printing strings
in dots was not documented, not really supported (as far as scaling is
concerned) and not covered by a regtest, as far as I can tell.

Therefore I did not pay attention to keep this functionality while
creating the patch for
Issue 2752: Parenthesize dots in fretboards
[...]
"

Consequences:
First, I'll update Issue 4120
https://code.google.com/p/lilypond/issues/detail?id=4120
label it regression.

Second, provide a patch as soon I'll find some time.


Though, the main question(s):
Why was the regtest not trigered?
Leading to:
Can we trust our regression-tests anymore?


Cheers,
  Harm