Re: Music function in LY file triggers error message

[James]

On Sat, 2021-02-13 at 13:29 +0100, Johannes Feulner wrote:
> HI there,
> 
> updating from LilyPond version 2.19.53 to 2.23.1 I found unexpected 
> non-fatal error messages in LilyPonds output whenever a music
> function 
> is defined:
> 
> Analysieren...
> Programmierfehler: Parsed object should be dead #<Prob: Music C++: 
> Music((void . #t))((name . Music) (types)) >
> 
> This happens even if a defined music function is never called.
> 
> Minimal example:
> 
>     \version "2.23.1"
>     myFunc =
>     #(define-music-function (parser location m)
>        (ly:music?)
>        m)
> 
> By the way: Are parser and location though no necessary anymore 
> deprecated/still allowed/make sense/bad style?
> 
> Cheers,
> 
> Johannes
> 

I saw the other replies ... but just because I took the time ...

git bisect gives me this:

--snip--

78225bc1b386e12dc1d03a5d2c7a017c0a52a22d is the first bad commit
commit 78225bc1b386e12dc1d03a5d2c7a017c0a52a22d
Author: Valentin Villenave <valentin@villenave.net>
Date:   Mon Jan 14 19:02:13 2019 +0100

    Chord names clean-up; no more Banter, exceptionsPartial or
\powerChords.
    
    This rather large patch
    
      - removes the legacy code for unsupported non-Ignatzek chord
names;
    that code hasn’t been working properly for nearly 15 years anyway,
see
    
https://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00288.html
    
      - stores a version of this code, with minor corrections, as a
    self-contained snippet (for historical purposes mainly), both
    on the LSR (as an upgrade to snippet #102) and included in
    Documentation/snippets.
    
      - as a result, chord-generic-names.scm is no longer found in scm/
    and the chord-names-jazz.ly doc chart no longer includes any
    alternative chord naming systems (that were already broken anyway).
    
      - chordNamesExceptionsFull and chordNamesExceptionsPartial
    properties have been removed as well (both having no longer had
    any effect whatsoever for quite some time).
    
      - the main (and now only) chordNamesExceptions property def
    has been slightly updated for slightly neater glyphs and spacing
    (e.g. chord modifiers, triangles and circles, are now printed
    consistently with all other superscripts) and so as to now include
    power chords by default; as a result, \powerChords is no longer
    needed, thereby solving any possible confusion with \germanChords
    and the like.  It’s rather unlikely that any user would type
    \chords{c:5} in order to get the same output as \chords{c}.
    
      - the documentation has been updated as well; convert rules
    have been added.

--snip--

James