Re: another core dump to be fixed before 1.4.5

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 6/2/2006 7:31 AM:
> And here's the proposed patch.  I will wait a couple days for comments
> before applying this, since it changes the semantics of traceon and
> traceoff (although it changes them to match how CVS head treats them).  In
> the process, I also noticed that ifdef(`foo') was incorrectly treating foo
> as defined in the same situations that indir(`foo') was crashing.
> 
> 2006-06-02  Eric Blake  <address@hidden>
> 
>       Solve crash when passing "indir(`foo')" to "m4 -tfoo".
>       * src/symtab.c (lookup_symbol) <SYMBOL_DELETE, SYMBOL_POPDEF>:
>       Preserve placeholder when macro is being traced.
>       * src/builtin.c (m4_ifdef, m4_indir): A traced but undefined
>       symbol is not defined.
>       (set_trace): Remove placeholder when no longer traced.
>       (m4_traceon): On named traces, always reserve a slot in the
>       symbol table.
>       (m4_traceoff): Don't warn about untracing a nonexistent symbol.
>       * NEWS: Document new trace behavior.
>       * doc/m4.texinfo (Trace): Tracing by name now consistently works
>       no matter whether that macro is currently defined.
>       (Incompatibilities): Document differences between traditional and
>       GNU trace.

FYI: I applied this; I will be posting a followon cleanup patch.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEhXUD84KuGfSFAYARAlI4AKCfhMyfO8hw5Tj3lVQVRXvirCSiXQCgreF0
gRqodmGrNniJnOtreFM3WzU=
=u/dL
-----END PGP SIGNATURE-----