Re: m4-1.4.7: inconsistency in src/m4.h

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[Oops, sorry for not including the list.]

- -------- Original Message --------
Subject: m4-1.4.7: inconsistency in src/m4.h
Date: Fri, 13 Oct 2006 10:56:59 -0700

Martin Koeppe wrote:
> 
> 
> Hello,
> 
> in src/m4.h I found, that the test for _POSIX_VERSION should only be 
> made, after unistd.h has been included. Otherwise the test should be 
> omitted, as _POSIX_VERSION gets #defined in <unistd.h>.

Thanks for the report.  Which platform was this on?  Did the test suite
still pass in spite of this?  The goal of that preprocessor check is to
find if any one of a number of macros is defined, in order that the rest
of the code can assume general Unix semantics and define the __unix__ m4
macro.  If that macro still ended up defined on your platform, then the
test suite will pass,  and I don't need to worry about this.  But if it
caused a testsuite failure, then I am more than willing to rearrange the
code slightly.

By the way, M4 can include <unistd.h> blindly, thanks to gnulib
portability code (and in fact, already does so, via "unistd--.h" lower
down in m4.h).  There is no need to check for HAVE_UNISTD_H, only to
rearrange the gnulib header inclusion to occur prior to the platform macro
detection section.

- --
Eric Blake
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFL9wy84KuGfSFAYARAkgWAKCctDxFInR4Yowxwydk5YIBcGbPPACg0eol
vHcIczTYGwK9NhrmghiDZhY=
=7dF7
-----END PGP SIGNATURE-----