bug-m4
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: git master should use gnulib module snprintf


From: Eric Blake
Subject: Re: git master should use gnulib module snprintf
Date: Sat, 13 Jun 2009 08:42:23 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 6/12/2009 5:06 AM:
> Hi Eric,
> 
> git master M4 uses snprintf in m4/output.c but does not use the snprintf
> module from gnulib.  This leads to a link error on Tru64/OSF1:

Thanks for the report.  Fixed as follows, also affected branch-1.6:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkozus8ACgkQ84KuGfSFAYCYnwCgxSikYB9+KW4tJLLMC3K0WSPl
TXoAn1+sKFhIDUQY2Ru7oBTn4WX/1VWP
=xZ+v
-----END PGP SIGNATURE-----
>From e6a31a7b140bc717b5320e1dcb588eea46a6839c Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Sat, 13 Jun 2009 08:04:12 -0600
Subject: [PATCH] Avoid snprintf link failures.

* ltdl/m4/gnulib-cache.m4: Import snprintf-posix module.
Reported by Ralf Wildenhues.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog               |    6 ++++++
 ltdl/m4/gnulib-cache.m4 |    3 ++-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 815be00..3b356c1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-06-13  Eric Blake  <address@hidden>
+
+       Avoid snprintf link failures.
+       * ltdl/m4/gnulib-cache.m4: Import snprintf-posix module.
+       Reported by Ralf Wildenhues.
+
 2009-06-12  Ralf Wildenhues  <address@hidden>

        Avoid pointer arithmetic on `void *'.
diff --git a/ltdl/m4/gnulib-cache.m4 b/ltdl/m4/gnulib-cache.m4
index e9b234d..d72313b 100644
--- a/ltdl/m4/gnulib-cache.m4
+++ b/ltdl/m4/gnulib-cache.m4
@@ -15,7 +15,7 @@


 # Specification in the form of a command-line invocation:
-#   gnulib-tool --import --dir=. --local-dir=local --lib=libgnu 
--source-base=gnu --m4-base=ltdl/m4 --doc-base=doc --tests-base=tests/gnu 
--aux-dir=build-aux --with-tests --libtool --macro-prefix=M4 assert autobuild 
avltree-oset binary-io clean-temp cloexec close-stream closein config-h 
configmake dirname error execute exit fdl-1.3 fflush filenamecat flexmember 
fopen fopen-safer freadptr freadseek fseeko gendocs gettext git-version-gen 
gnumakefile gnupload gpl-3.0 intprops memchr2 memcmp2 memmem mkstemp obstack 
obstack-printf-posix pipe progname propername quote regex regexprops-generic 
rename sprintf-posix stdbool stdlib-safer strnlen strtod strtol tempname 
unlocked-io vasnprintf-posix verify verror wait-process xalloc xalloc-die 
xmemdup0 xprintf-posix xstrndup xvasprintf-posix
+#   gnulib-tool --import --dir=. --local-dir=local --lib=libgnu 
--source-base=gnu --m4-base=ltdl/m4 --doc-base=doc --tests-base=tests/gnu 
--aux-dir=build-aux --with-tests --libtool --macro-prefix=M4 assert autobuild 
avltree-oset binary-io clean-temp cloexec close-stream closein config-h 
configmake dirname error execute exit fdl-1.3 fflush filenamecat flexmember 
fopen fopen-safer freadptr freadseek fseeko gendocs gettext git-version-gen 
gnumakefile gnupload gpl-3.0 intprops memchr2 memcmp2 memmem mkstemp obstack 
obstack-printf-posix pipe progname propername quote regex regexprops-generic 
rename snprintf-posix sprintf-posix stdbool stdlib-safer strnlen strtod strtol 
tempname unlocked-io vasnprintf-posix verify verror wait-process xalloc 
xalloc-die xmemdup0 xprintf-posix xstrndup xvasprintf-posix

 # Specification in the form of a few gnulib-tool.m4 macro invocations:
 gl_LOCAL_DIR([local])
@@ -63,6 +63,7 @@ gl_MODULES([
   regex
   regexprops-generic
   rename
+  snprintf-posix
   sprintf-posix
   stdbool
   stdlib-safer
-- 
1.6.3.rc3.2.g4b51


reply via email to

[Prev in Thread] Current Thread [Next in Thread]