bug-m4
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: doc: Simple grammar fix


From: Eric Blake
Subject: Re: doc: Simple grammar fix
Date: Thu, 25 Jun 2009 06:35:28 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Elias Benali on 6/24/2009 8:39 PM:
> Shouldn't the correct usage be "the number and aggregate size of
> diversions are limited" instead of "is limited" ?

Yes, but that's still passive voice.  And the overall paragraph overuses
forms of the word 'limit', which is counter to the whole idea that m4
strives to have no arbitrary limits.

> If so a patch is included to fix it.

Thanks!  I wish all bug reports came with proposed patches.  m4.info-1 is
generated, so only m4.texinfo needs to be patched.  Here's what I'm pushing:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpDbxAACgkQ84KuGfSFAYBJAACeOiIiC3ZekoWUXJvv1CkGIJ0f
VYAAn1vxpeGdkFQox0+TbRdg4rkw7mJP
=rFzn
-----END PGP SIGNATURE-----
>From 59658f499a3e1c2675e7ba6b264dc37e24a57b25 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Thu, 25 Jun 2009 06:32:15 -0600
Subject: [PATCH] Fix description of limits on diversions.

* doc/m4.texinfo (Diversions): Fix grammar.  Be less pessimistic
about limitations.
* THANKS: Update.
Reported by Elias Benali.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog      |    8 ++++++++
 doc/m4.texinfo |    9 ++++-----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e675616..1a8a7c3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-06-25  Eric Blake  <address@hidden>
+
+       Fix description of limits on diversions.
+       * doc/m4.texinfo (Diversions): Fix grammar.  Be less pessimistic
+       about limitations.
+       * THANKS: Update.
+       Reported by Elias Benali.
+
 2009-06-17  Eric Blake  <address@hidden>

        Update to latest gnulib.
diff --git a/doc/m4.texinfo b/doc/m4.texinfo
index 1c5230a..48aa74e 100644
--- a/doc/m4.texinfo
+++ b/doc/m4.texinfo
@@ -5090,17 +5090,16 @@ Diversions

 @cindex @env{TMPDIR}
 Numbered diversions are counted from 0 upwards, diversion number 0
-being the normal output stream.  The number of simultaneous diversions
-is limited mainly by the memory used to describe them, because @acronym{GNU}
+being the normal output stream.  @acronym{GNU}
 @code{m4} tries to keep diversions in memory.  However, there is a
-limit to the overall memory usable by all diversions taken altogether
+limit to the overall memory usable by all diversions taken together
 (512K, currently).  When this maximum is about to be exceeded,
 a temporary file is opened to receive the contents of the biggest
 diversion still in memory, freeing this memory for other diversions.
 When creating the temporary file, @code{m4} honors the value of the
 environment variable @env{TMPDIR}, and falls back to @file{/tmp}.
-So, it is theoretically possible that the number and aggregate size of
-diversions is limited only by available disk space.
+Thus, the amount of available disk space provides the only real limit on
+the number and aggregate size of diversions.

 @ignore
 @comment We need to test spilled diversions, but don't need to expose
-- 
1.6.3.3.334.g916e1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]