Re: m4 1.4.16 compilation error on SunOS 5.10: __attribute__

[Eric Blake]

On 12/07/2011 07:14 PM, Claus Assmann wrote:
> I just tried to compile m4-1..4.16 on a SunOS 5.10 machine with Sun's compiler
> and got this error:
> 
> /opt/SUNWspro/bin/cc -fast -xtarget=generic  -xc99=all  -I.      -g -c 
> verror.c
> "verror.h", line 35: syntax error before or at: __attribute__

Thanks for the report.

> 
> 
> A possible patch follows:
> 
> --- lib/verror.h-     Wed Dec  7 16:41:06 2011
> +++ lib/verror.h      Wed Dec  7 16:41:08 2011
> @@ -32,7 +32,7 @@
>  
>  extern void verror (int __status, int __errnum, const char *__format,
>                      va_list __args)
> -     __attribute__ ((__format__ (__printf__, 3, 0)));
> +     _GL_ATTRIBUTE_FORMAT ((__format__ (__printf__, 3, 0)));

Not quite right.  Upstream gnulib already fixed it:
 git.sv.gnu.org/cgit/gnulib.git/commit/?id=f93da2171bca

The next m4 release will be fixed; meanwhile, you can use the gnulib
diff to fix it properly.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature