[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix M4 build on DragonFly BSD
From: |
GW |
Subject: |
Re: [PATCH] Fix M4 build on DragonFly BSD |
Date: |
Tue, 05 Nov 2013 17:43:21 +0100 |
User-agent: |
KMail/4.11.2 (Linux/3.11.6-1-ARCH; KDE/4.11.2; x86_64; ; ) |
On Tuesday 05 November 2013 09.03:17 Eric Blake wrote:
> [adding bug-gnulib]
>
> On 11/05/2013 08:55 AM, GW wrote:
> > M4 does not build "as is" on DragonFly BSD. However, the fix we found and
> > used for a while at DragonFly is actually fairly simple:
> >
> >
> > --- lib/fpending.h.orig 2013-11-05 16:23:53.676412000 +0100
> > +++ lib/fpending.h 2013-11-05 16:25:14.837659000 +0100
> > @@ -24,6 +24,8 @@
> >
> > # include <stdio_ext.h>
> > #endif
> >
> > +#ifndef __DragonFly__
> >
> > #ifndef __fpending
> > size_t __fpending (FILE *);
> > #endif
> >
> > +#endif
>
> Thanks; but this needs to be patched upstream in gnulib (the next m4
> release will pick up the gnulib fix).
Sounds good to me. :-)
Thanks.
> Furthermore, your patch isn't
> quite right; we need to figure out WHY your build is failing if we
> redeclare __fpending on DragonFly, rather than just #ifdef'ing it out.
> Can you post the actual compiler message?
Sure. See attachments.
This build attempt was made on a development version of DragonFly, x86_64:
DragonFly odin-dfly.localhost 3.5-DEVELOPMENT DragonFly v3.5.0.1306.ga5c6f-
DEVELOPMENT #5: Mon Nov 4 14:28:45 CET 2013 address@hidden
dfly.localhost:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64
dfly_M4-1.4.17_configure.log
Description: Text Data
dfly_M4-1.4.17_make.log
Description: Text Data
- [PATCH] Fix M4 build on DragonFly BSD, GW, 2013/11/05
- Re: [PATCH] Fix M4 build on DragonFly BSD, Eric Blake, 2013/11/05
- Re: [PATCH] Fix M4 build on DragonFly BSD,
GW <=
- Re: [PATCH] Fix M4 build on DragonFly BSD, Eric Blake, 2013/11/05
- Re: [PATCH] Fix M4 build on DragonFly BSD, GW, 2013/11/05
- Re: [PATCH] Fix M4 build on DragonFly BSD, Eric Blake, 2013/11/05
- Re: [PATCH] Fix M4 build on DragonFly BSD, GW, 2013/11/05
- [PATCH] fpending: fix regression on DragonFly BSD, Eric Blake, 2013/11/08
- Re: [PATCH] fpending: fix regression on DragonFly BSD, Paul Eggert, 2013/11/08
- Re: [PATCH] fpending: fix regression on DragonFly BSD, Eric Blake, 2013/11/08
- Re: [PATCH] fpending: fix regression on DragonFly BSD, Robin Hahling, 2013/11/08