[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: recent changes to obstacks cause many out of memory failures in M4 m
|
From: |
Eric Blake |
|
Subject: |
Re: recent changes to obstacks cause many out of memory failures in M4 master testsuite |
|
Date: |
Fri, 05 Dec 2014 12:11:10 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/05/2014 12:03 PM, Gary V. Vaughan wrote:
> Bisecting my way to the the first gnulib changeset that causes these
> failures, I landed at:
>
> bb2ab7e 2014-10-29 14:02 Alan Modra obstack: 64-bit obstack support, part
> 2
>
> Which is not surprising as GNU M4 uses GNU obstack extensively throughout.
I bet it has to do with this:
src/builtin.c: obstack_blank (data->obs, sizeof (symbol *));
src/builtin.c: obstack_blank_fast (obs, len);
src/builtin.c: obstack_blank (obs, -1);
src/macro.c: obstack_blank is documented to take a negative size to
reduce the
src/macro.c: obstack_blank (&argv_stack, -argc * sizeof (token_data *));
vs. the discussion on gnulib that we intentionally changed upstream
obstack_blank to no longer do this, and that you HAVE to use
obstack_blank_fast to get that effect.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature