[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #62615] Fix the leaks of file->cmds and file->cmds->commands
From: |
Dmitry Goncharov |
Subject: |
[bug #62615] Fix the leaks of file->cmds and file->cmds->commands |
Date: |
Wed, 15 Jun 2022 21:55:00 -0400 (EDT) |
Follow-up Comment #1, bug #62615 (project make):
Paul, can you please ignore this patch?
This bug report is correct, there is a memory leak.
But the patch is not correct. The patch fails to take into account a case when
multiple targets are defined on the same rule. Correctly taking care of
freeing commands in cases like
++++
bye.o hello.o: hello.h; $(info 1 $@ from $^)
hello.o: hello.c; $(info 2 $@ from $^)
----
requires additional bookkeeping, like reference counters or similar. This
patch does not do any of that.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?62615>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/