Re: [PATCH 1/2] Fix duplicated __strchrnul() declaration error on OS/2 kLIBC

[KO Myung-Hun]

Hi/2.

Paul Smith wrote:
> On Wed, 2022-11-09 at 22:45 +0900, KO Myung-Hun wrote:
>> OS/2 kLIBC has __strchrnul(). But HAVE___STRCHRNUL is undefined.
>> 'static' declarion of __strchrnul() causes an error with gcc4 because
>> OS/2 kLIBC declares __strchrnul() as public.
> 
> I assume kLIBC is a libc implementation for OS/2?
> 

Yes. kLIBC is a successor of EMX.

> I'm not sure I like this solution, mainly because fnmatch.c and glob.c
> are "inherited" from gnulib and I don't like to change them (although
> they are very far divorced from upstream at this point).
> 
> My understanding of the problem is that we are missing a
> HAVE__STRCHRNUL.  Wouldn't it make more sense to add that to the
> config.h?
> 

Ok, I've attached a new patch.

> But, I don't quite understand how the configure works on OS/2.  Can you
> clarify whether the steps in the README.OS2 document are still correct?
> Do you indeed run the configure script etc. and is there enough support
> on OS/2 for that to work?
> 
> Maybe the first thing that needs to be done is to review the contents
> of the README.OS2 and verify that it still is all valid, and if not
> submit changes to make it correct.
> 

I've updated README.OS2 in according to the latest environment.

Ah, the patches are based on 4.4 tar ball release.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.40 on Intel Core i7-3615QM 2.30GHz with 12GB RAM

Korean OS/2 User Community : http://www.os2.kr/

0001-Define-a-HAVE___STRCHRNUL-macro-properly.patch
Description: Source code patch

0001-Update-README.OS2.patch
Description: Source code patch