bug-mcron
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-mcron] [PATCH 33/33] core: Use SRFI-9 records for the job data


From: Mathieu Lirzin
Subject: Re: [Bug-mcron] [PATCH 33/33] core: Use SRFI-9 records for the job data structure.
Date: Sun, 18 Oct 2015 21:57:20 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Mathieu Lirzin <address@hidden> writes:

> * scm/mcron/mcron-core.scm <job>: New record type.  This Replaces a
>   vector data structure.  All consumers changed.
> ---
>  scm/mcron/mcron-core.scm | 93 
> ++++++++++++++++++++++++------------------------
>  1 file changed, 46 insertions(+), 47 deletions(-)
>
> diff --git a/scm/mcron/mcron-core.scm b/scm/mcron/mcron-core.scm
> index 518bcac..a10ec97 100644
> --- a/scm/mcron/mcron-core.scm
> +++ b/scm/mcron/mcron-core.scm
[...]
> +;; A cron job.
> +(define-record-type <job>
> +  (make-job user time-proc action environment displayable next-time)
> +  job?
> +  (user        job:user)                ;string : user passwd entry
                                            ^^^
> +  (time-proc   job:next-time-function)  ;proc   : with one 'time' parameter
> +  (action      job:action)              ;thunk  : user's code
> +  (environment job:environment)         ;alist  : environment variables
> +  (displayable job:displayable)         ;string : visible in schedule
> +  (next-time   job:next-time            ;number : time in UNIX format
> +               job:next-time-set!))


This was incorrect since this field is for objects returned by the
‘getpw’ procedure.  Actually this object has a vector type but since
Guile's documentation doesn't specify it and provides accessors for its
members, I have chosen to use the generic term “object”.

Here is the updated patch

Attachment: 0001-core-Use-SRFI-9-records-for-the-job-data-structure.patch
Description: Text Data

--
Mathieu Lirzin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]