Re: [Bug-mcron] '(next-jour '(0)) no longer matched

[Ludovic Courtès]

Hello,

Mathieu Lirzin <address@hidden> skribis:

> address@hidden (Ludovic Courtès) writes:
>
>> I’m getting this:
>>
>> $ sudo "/gnu/store/y4q8cjjzjvq3d6xq3v0vim5q3ymcl0im-mcron-1.1"/bin/mcron 
>> "/gnu/store/z8mkighcbz0a3v1faqgh97wlggrd8mv1-mcron-job"
>> Backtrace:
>>            8 (apply-smob/1 #<catch-closure 106b3a0>)
>> In mcron/scripts/mcron.scm:
>>      81:2  7 (main _)
>> In ice-9/boot-9.scm:
>>    260:13  6 (for-each #<procedure 7fc3119bea28 at mcron/scripts/mc?> ?)
>>    2312:4  5 (save-module-excursion #<procedure 10720c0 at ice-9/boo?>)
>>   3822:12  4 (_)
>> In mcron/base.scm:
>>    103:25  3 (add-job #<procedure ffd660 at mcron/job-specifier.scm?> ?)
>> In mcron/job-specifier.scm:
>>    251:32  2 (_ 1522057507)
>>      91:5  1 (bump-time #(0 0 11 26 2 118 1 84 1 -7200 "CEST") _ #<?> ?)
>>      63:4  0 (%find-best-next _ _)
>>
>> mcron/job-specifier.scm:63:4: In procedure %find-best-next:
>> Throw to key `match-error' with args `("match" "no matching pattern" 0)'.
>> $ cat "/gnu/store/z8mkighcbz0a3v1faqgh97wlggrd8mv1-mcron-job"
>> (job (quote (next-hour (quote (0)))) (lambda () (system* 
>> "/gnu/store/286wkzgs9hzhrc8wix4pani7dwkqrgm4-rottlog-0.72.2/sbin/rottlog")))
>>
>> This job spec used to work before 1.1.  Any ideas?
>
> Yes, the main issue was introduced 2 years ago when replacing a dotted
> optional arguments list with an #:optional keyword and not adapting a delegate
> procedure. :-(
>
> This shameful bug should be fixed by commits
> f71b0b8310e6b297866147a11e3fd0dd5db13beb and
> fad58ca8c221def75093463e917f66fc006f3df5.

Awesome!

> IMO This bug definitely requires a bug-fix release.  I will continue my
> automatic testing endeavor for a bit before releasing 1.1.1.

Heheh, sounds good.  :-)

Thank you!

Ludo’.