[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-mcron] Documentation error (every second sunday)
From: |
Mathieu Lirzin |
Subject: |
Re: [Bug-mcron] Documentation error (every second sunday) |
Date: |
Mon, 11 Feb 2019 23:19:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello Adam,
Adam Tack <address@hidden> writes:
> Thanks for the kind reply!
>
>> > (Arguably ~second-sunday~ as a variable name is a bit of a misnomer.)
>> Have you a better name in mind?
>
> The best thing that came to mind was ~second-sunday-increment~, but
> I'm not sure whether it conveys the idea that it's not the relevant
> day of the month, but the amount we add to the first of the month,
> well.
While I agree with the ambiguity, I found that name a bit long so I keep
‘second-sunday’ for now. :-)
>> I think it might be helpful to add a test case for this. Are you
>> interested in doing so?
>
> I'm interested, though I'm not sure when I'll have it ready by.
No problem,
In the meantime, Are you OK if I commit the documentation fix in your
name with the following rationale?
--8<---------------cut here---------------start------------->8---
doc: Fix “Every second Sunday” example
* doc/mcron.texi (Every second Sunday): If the first day of the month is
Sunday, then the second Sunday of the month is seven days later not
eight.
--8<---------------cut here---------------end--------------->8---
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
- Re: [Bug-mcron] Documentation error (every second sunday),
Mathieu Lirzin <=