[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] base: Call 'child-cleanup' when 'select' returns an empt

From: Dale Mellor
Subject: Re: [PATCH 3/5] base: Call 'child-cleanup' when 'select' returns an empty set.
Date: Fri, 28 Feb 2020 00:07:49 +0000
User-agent: Evolution 3.30.5-1.1

On Sun, 2020-02-23 at 18:49 +0100, Ludovic Courtès wrote:
> Previously, on Guile >= 2.2, we'd lose this opportunity to call
> 'child-cleanup', possibly leaving zombies behind us.
> * src/mcron/base.scm (run-job-loop): Define 'select*'.  Don't expect
> 'select*' to throw upon EINTR or EAGAIN.
>  ...

Thanks for this!  I remember this basic code from way back when I first
started writing mcron; guile 1.3.4 was the current version and it was
impossible then to deal with process signals and select calls in the
same program.  When guile 2.0 came out I did a quick hack (actually it
took a lot of trial and error to find something that worked) which made
it work at least most of the time and don't think that I have looked at
it since.

But times have moved on, and now you've got it working like it should. 

I've committed your updates to the upstream repository.

Best wishes,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]