Re: Minor bugs

[Thomas Dickey]

On Fri, Jul 19, 2002 at 05:44:50AM +0200, Philippe Blain wrote:
> >From Philippe Blain, Bordeaux, FRANCE - pblain @ free.fr
> My old computer:P133 - 8, 4 Go - 32 Mo Red Hat Linux 7.0
> 
> To maintainers of 'ncurses'.(and to Mr Dickey)
> Subject: Minor corrections for ncurses-5.2-20020713+
> 
> Here are some problems I found:
> 
> ----------------------------------------------------------------------------
> ----
> File:ncurses/base/lib_newterm.c
> 
> Function _nc_initscr ()
> 
> Same thing as in lib_raw.c
> Use of a buffer to prevent updating if function fails :

oops - I thought I looked for similar usage (probably was looking only at
callers of lib_raw.c)

> ----------------------------------------------------------------------------
> ----
> File:ncurses/base/lib_screen.c
> 
> Function scr_init ()
> 
> If you remove the test on dumptime, you can remove fstat and stb also.
> 
> Before 20020713 :
> -    else if (fstat(STDOUT_FILENO, &stb) || stb.st_mtime > dumptime)
> After 20020713 :
> +    } else if (fstat(STDOUT_FILENO, &stb)) {
>   returnCode(ERR);

not exactly - the fstat is doing an existance-check (I looked to see if there
was some nicer function in ncurses that I could merge this with, but didn't
see one)
 
> ----------------------------------------------------------------------------
> ----
> File:ncurses/base/lib_ttyflags.c
> 
> Function reset_prog_mode ()
> 
> Need to test the return value of '_nc_set_tty_mode' before returning an
> appropriate error code for the function.
> Something like that :
> 

( thanks ;-)

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net