Re: Corrections for 20030906

[Thomas Dickey]

On Wed, 10 Sep 2003, Philippe Blain wrote:

> NOTE also that the changes (NEWS 20030802) in _nc_safe_strcat()
> and _nc_safe_strcpy(), has been reverted (due to some backup ??) :
>     s_size is decremented even if s_tail is NULL, and src not copied.

I reverted them because the proposed change was incorrect (did not notice
immediately, but during retesting it was apparent ;-).

> /* Why the case (xold > 0) treated in the while() loop ??? */

I don't recall - will see.

> 4-----------------------------------------------------------------------
> File : ncurses/tty/lib_tputs.c
>
>     static int (*my_outch) (int c) = _nc_outch;
>
> Introduced for delay_output(), static 'my_outch' can be removed by
> passing delay_output() the same parameter as tputs() :
>
>     delay_output (int ms, int (*outc) (int))

but delay_output's prototype is defined by X/Open.

> 7-----------------------------------------------------------------------
> nl() & nonl()
>
> If the ICRNL mode is simulated (lib_getstr.c),  the translation
> NL -> CRLF on OUTPUT seems NOT to be done by software (see PutAttrChar).

I don't see that.  The only related code is in mvcur...

> Think it's easier to call _nc_set_tty_mode() with correct flags in nl()
> and nonl() and let the tty driver do the job than the software way
> adopted.

I seem to recall some related change long ago - will have to read & see.

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net