menu_opts_off(menu, O_SHOWDESC) fails to recalculate geometry

[Adam Spragg]

Program that shows the bug attached. As far as I can tell from the 
documentation for scale_menu(), line 3 of the program's output should 
be the same as line 1, but is instead the same as line 2.

I am running libncurses 5.6 from Debian unstable, but have traced the 
bug down to source code in the official ftp.gnu.org sources. The 
problem appears to be on lines 93-94 of menu/m_opts.c, where the menu 
geometry is recalculated if O_SHOWDESC is switched on, but not if it is 
switched off.

Interestingly, O_SHOWDESC is normally the default, so most people will 
never actually be in the position of turning O_SHOWDESC on. Turning 
O_SHOWDESC off will be the most common operation (which is how I came 
across the bug - I was creating a menu and turning off O_SHOWDESC as 
soon as I possibly could without affecting global state) yet that is 
the one that is broken. How odd...

Adam

-- 
Adam Spragg                      mailto:address@hidden
Developer
Octal Telecom                           http://www.octaltelecom.co.uk/


It reverses the logical flow of conversation!
> Why?
> > No.
> > > Should I top post?

http://www.google.com/search?q=%22top+posting%22

menushowdesc.c
Description: Text Data