Race condition during ncurses installation

[Bystricky, Juro]

Hello ncurses maintainers,

 

There is a race condition using parallel make installing ncurses when installing explicit targets:

 

make install.libs install.includes

 

Both targets install identicall files, often resulting in an error such as :

/usr/bin/install: cannot create regular file '/data/master-ab/poky/build-ab/tmp/work/core2-64-poky-linux/ncurses/6.0+20160213-r0/image/usr/include/termcap.h': File exists

 

The race is relatively easy to fix, i.e. add statement such as

 

.NOTPARALLEL install.libs install.includes

 

in the file mk-hdr.awk

While this would prevent the race, several identical files would be still

installed twice (still assuming installing via “make install.libs install.includes “).

 

Is it fair to assume install.libs is a superset of install.includes?

In other words, is

 

make install.libs

 

meant to be an equivalent to:

 

make install.libs install.includes

 

BTW, I should mention that “make install.libs install.includes” has been used in Yocto ncurses recipes

for years (instead of a generic “make install”) in order to better granulate installed ncurses components.

 

Thanks

 

Juro Bystricky