Re: NCURSES_CH_T definition and ncurses.h in toolchain sys-root include path

[Thomas Dickey]

On Mon, Sep 19, 2016 at 12:52:52PM -0700, Florian Fainelli wrote:
> On 09/17/2016 01:50 PM, Thomas Dickey wrote:
> > On Tue, Sep 13, 2016 at 05:31:14PM -0700, Florian Fainelli wrote:
> >> Hi all,
> >>
> >> While debugging the following build failure encountered with building
> >> libncursesw:
> >>
> >> arm-linux-gnueabihf-gcc -DHAVE_CONFIG_H -I../ncurses -I.
> >> -I/exp00/fainelli/openwrt/trunk/staging_dir/target-arm-linux-gnueabihf/usr/include
> >> -I/exp00/fainelli/openwrt/trunk/staging_dir/target-arm-linux-gnueabihf/include
> >> -I/opt/toolchains/stbgcc-4.8-1.5//usr/include
> >> -I/opt/toolchains/stbgcc-4.8-1.5//include  -D_GNU_SOURCE
> >> -D_FILE_OFFSET_BITS=64  -DNDEBUG -I. -I../include -Os -pipe
> >> -march=armv7-a -mtune=cortex-a15 -fno-caller-saves -mfloat-abi=hard
> >> -fpic   --param max-inline-insns-single=1200 -fPIC -c
> >> ../ncurses/./tty/hashmap.c -o ../obj_s/hashmap.o
> > 
> > I am puzzled by this: in the scenarios that I have considered, none of
> > them insert these options between "-I." and "I../include":
> > 
> >     
> > -I/exp00/fainelli/openwrt/trunk/staging_dir/target-arm-linux-gnueabihf/usr/include
> >     
> > -I/exp00/fainelli/openwrt/trunk/staging_dir/target-arm-linux-gnueabihf/include
> >     -I/opt/toolchains/stbgcc-4.8-1.5//usr/include
> >     -I/opt/toolchains/stbgcc-4.8-1.5//include  -D_GNU_SOURCE
> >     -D_FILE_OFFSET_BITS=64  -DNDEBUG
> > 
> > rather, the options fall after the "-I../include".
> > 
> > Which patchlevel of ncurses are you building, and what environment and
> > command-line options are you using?
> 
> 
> patchlevel: 5.9 w/ the following patches applied:
> 
> http://git.openwrt.org/?p=15.05/openwrt.git;a=tree;f=package/libs/ncurses/patches;h=044ac197cc84d079b3df5dab43984553e5c3e8f6;hb=HEAD

5.9 is a little old (2011):

http://invisible-island.net/ncurses/NEWS.html#t20110404

Just looking at the NEWS file, I think this change in 2012 is where
I fixed that:

http://invisible-island.net/ncurses/NEWS.html#t20121110

        + modify configure macro CF_INCLUDE_DIRS to put $CPPFLAGS after the
          local -I include options in case someone has set conflicting -I
          options in $CPPFLAGS (prompted by patch for ncurses/Makefile.in by
          Vassili Courzakis).

(the config.status was helpful)

> #define NCURSES_VERSION_STRING "5.9.20110404"

The current release (6.0) is about a year old (also with fixes).
Perhaps someone could update those patches on openwrt...

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature