Re: Update terminfo entry for 'iterm'

[Leonardo Brondani Schenkel]

On 2017-08-16 10:14, Thomas Dickey wrote:
> On Wed, Aug 16, 2017 at 07:27:22AM +0200, Leonardo Brondani Schenkel wrote:
> > Which version did you test? I have iTerm2 3.0.15 and italic
> > definitely works (just tested again now), and on
> > Preferences/Profiles/Text there's a checkbox that says "Italic text
> > allowed". I *think* I never changed the default profile (I have a
> > custom one) and it is enabled in my box.
>
> looking again, I see the setting (I was looking for "Font"...).
> I'm certain that I did not change it - see attached screenshot.
>
> Of course, documentation (i.e., a manual listing the default settings)
> would be useful.  I was reading the sources, found no documentation
> aside from a couple of readme's and program comments.

I'm not a Mac developer, so I may be misinterpreting this, but I found 
these two places which may be the defaults:

https://github.com/gnachman/iTerm2/blob/master/plists/DefaultBookmark.plist#L245

https://github.com/gnachman/iTerm2/blob/master/sources/iTermProfilePreferences.m#L251

But just for the sake of argument and my own understanding of your 
reasoning, if we assume that the default for the setting is "off", what 
would be the drawback of adding the italic sequences to terminfo? The 
end result would still be that italic wouldn't work for people who 
haven't enabled the setting (so no change there), but it would work 
otherwise (which is a plus). What am I missing from this trade-off?

// Leonardo.