[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
ncurses-6.0-20170722 breaks window resizing
From: |
Jeb Rosen |
Subject: |
ncurses-6.0-20170722 breaks window resizing |
Date: |
Tue, 29 Aug 2017 10:48:10 -0600 |
Arch Linux recently got an update to ncurses that broke window resizing
in weechat, so I bisected the ncurses releases and found that the endwin
state handling in 2017-07-22 was most likely at fault. The _endwin flag
was changed from a boolean to a tristate enum, and most of the checks
were updated to accomodate that, with TRUE becoming ewSuspend and FALSE
becoming ewRunning or ewInitial. However, one check in
ncurses/tty/tty_update.c changed a comparison to TRUE to a comparison to
ewRunning, in the size change handling.
The following change appears to more closely match the original logic,
and does fix weechat for me.
--- ncurses-6.0-20170827/ncurses/tty/tty_update.c 2017-08-27
13:40:17.000000000 -0600
+++ ncurses-6.0-20170827-patch/ncurses/tty/tty_update.c 2017-08-29
10:38:45.602673861 -0600
@@ -831,7 +831,7 @@
SP_PARM->_fifohold--;
#if USE_SIZECHANGE
- if ((SP_PARM->_endwin == ewRunning)
+ if ((SP_PARM->_endwin == ewSuspend)
|| _nc_handle_sigwinch(SP_PARM)) {
/*
* This is a transparent extension: XSI does not address it,
Is this a correct way to handle the change, or is there more to it?
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- ncurses-6.0-20170722 breaks window resizing,
Jeb Rosen <=