bug-ncurses
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] configure-time LDFLAGS leak into ncurses pkg-config file


From: Michael Stapelberg
Subject: [PATCH] configure-time LDFLAGS leak into ncurses pkg-config file
Date: Thu, 7 May 2020 09:22:35 +0200

When building ncurses with e.g. -Wl,-rpath=/ro/ncurses-amd64-6.2-9/lib
(to make it hermetic, see my work-in-progress post at
https://website-review.zekjur.net/pull/hermetic/posts/2020-05-04-distri-hermetic-packages/),
I noticed that the resulting pkg-config files (e.g.
lib/pkgconfig/ncursesw.pc) includes the LDFLAGS!

This will result in software that links against ncurses being built
with the wrong rpath.

In general, LDFLAGS should not be persisted into pkg-config. The
attached patch fixes the issue.

Thanks,

Attachment: pc-ldflags.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]