Re: ANN: ncurses-6.2-20211016

[Milan P . Stanić]

On Sun, 2021-10-24 at 16:25, Thomas Dickey wrote:
> ----- Original Message -----
> | From: "Milan P. Stanić" <mps@arvanta.net>
> | To: "Thomas Dickey" <dickey@his.com>
> | Cc: "Ncurses Mailing List" <bug-ncurses@gnu.org>
> | Sent: Sunday, October 24, 2021 4:21:33 PM
> | Subject: Re: ANN: ncurses-6.2-20211016
> 
> | On Sun, 2021-10-24 at 15:28, Thomas Dickey wrote:
> |> On Sun, Oct 24, 2021 at 08:23:04PM +0200, Milan P. Stanić wrote:
> |> > On Sun, 2021-10-24 at 13:44, Thomas Dickey wrote:
> |> > > ----- Original Message -----
> |> > > | From: "Milan P. Stanić" <mps@arvanta.net>
> |> > > | To: "Ncurses Mailing List" <bug-ncurses@gnu.org>
> |> > > | Sent: Sunday, October 24, 2021 8:18:25 AM
> |> > > | Subject: Re: ANN: ncurses-6.2-20211016
> |> > > 
> |> > > | Hi Thomas,
> |> > > | 
> |> > > | On Sun, 2021-10-17 at 00:26, Thomas Dickey wrote:
> |> > > | [...]
> |> > > | 
> |> > > |> 20211016
> |> > > |>     + build-fix for pmake with libtool.
> |> > > |>     + improve make-tar.sh scripts, adding COPYING to tar file, and 
> clean up
> |> > > |>       shellcheck warnings.
> |> > > |>     + add link for "reset6" manpage in test-package ncurses6-doc
> |> > > |>     + revise configure option --with-pkg-config-libdir, using the 
> actual
> |> > > |>       search path from pkg-config or pkgconf using the output from 
> --debug
> |> > > |>       (report by Pascal Pignard).
> |> > > 
> |> > > https://invisible-island.net/ncurses/NEWS.html#t20211017
> |> > > 
> |> > >         + amend change for pkg-config to account for "none" being 
> returned in
> |> > >           the libdir-path result rather than "no" (report by Gabriele 
> Balducci).
> |> > 
> |> > Yes, my build log below is when building 6.2-20211017
> |> > 
> |> > Our option is only to make patch for configure to pass builders
> |> 
> |> for now - I'll have to sort it out and find a better solution
> |>  
> |> > > | 
> |> > > | this changes in configure introduced bug in Alpine linux builders
> |> > > | because they don't have /usr/lib/pkgconfig dir by default.
> |> > > | 
> |> > > | Here is part of  ./configure log:
> |> > > | -------------------------------------
> |> > > | checking for long file names... yes
> |> > > | checking if you want to use pkg-config... yes
> |> > > | checking for x86_64-alpine-linux-musl-pkg-config... no
> |> > > | checking for pkg-config... /usr/bin/pkg-config
> |> > > | checking for /usr/bin/pkg-config library directory... checking for 
> first
> |> > > | directory... none
> |> > > | checking if we should install .pc files for /usr/bin/pkg-config... 
> yes
> |> > > | configure: error: expected a pathname, not ""
> |> 
> |> I think that the fix for this may be small :-)
> | 
> | Would you mind to post this fix? I'm not much versed in
> | autoconf/configure and have 'fear' to make something bad for ncurses on
> | alpine linux now when we are in 'freeze' for next stable release.
> 
> Just before your mail, I sent a small patch which you could try,
> to verify that my proposed fix also works for you.  (I tested it
> here by renaming my "pkgconfig" directories to simulate the effect
> of not having any).

Thanks for fast fix.
Applied it and it works. I will test it more tomorrow because I'm tired
now (I'm in CET tz).

-- 
Kind regards 
> I'd also like to keep the changes small :-)

Agree, small patches are always better than big ones :-)
 
-- 
Kind regards 

> -- 
> Thomas E. Dickey <dickey@invisible-island.net>
> http://invisible-island.net
> ftp://ftp.invisible-island.net