Re: [bug-ncurses] ANN: ncurses-6.4-20230429

[Thomas Dickey]

On Tue, May 02, 2023 at 04:00:25AM -0400, Thomas Dickey wrote:
> On Tue, May 02, 2023 at 09:44:08AM +0200, Dr. Werner Fink wrote:
> > >  NEWS                             |   10 +++++++-
> > >  VERSION                          |    2 -
> > >  dist.mk                          |    4 +--
> > >  include/nc_access.h              |   14 ++++++------
> > 
> > [...]
> > 
> > >  
> > > 20230429
> > >   + revise recent change to _nc_write_entry to isolate it to a Cygwin bug
> > >     (cf: 20230311)
> > >   + amend fix for wgetnstr, wgetn_wstr to use cbreak mode unless raw
> > >     mode was set (cf: 20210522).
> > >   + fix a few warnings from cppcheck, etc.
> > >   + correct copy/paste error in nc_access.h (report by Werner Fink).
> > 
> > Guess:
> > 
> >  #define safe_open2(name,flags)      _nc_safe_open2(name,flags,0)
> > 
> > should be
> > 
> >  #define safe_open2(name,flags)      _nc_safe_open3(name,flags,0)
> 
> yes (hmm - I thought I was test-compiling with/without the feature,
> to catch stuff like this)

I overlooked that because it is used only for reading termcap data
(which I don't generally build for Debian(*) - that would be one of the BSDs).

This weekend, I test-built with Debian, MacOS, cygwin, msys2, mingw.
While MacOS is a BSD, no one has ever used it with real termcap :-)

(*) I'd do this if I were testing tctest, otherwise not, because the termcap
    data is always going to be less complete than the terminfo, and thus
    interfere with other uses.

-- 
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net

signature.asc
Description: PGP signature