Re: RCS 5.10.1 fails 6 tests on 2023 Mac Studio with macOS 15.0 Sequoia

[Collin Funk]

Paul Eggert <eggert@cs.ucla.edu> writes:

> Thanks for the bug report. I can't reproduce the problem with macOS
> 12.6 21G115. Please try running this command:

By the way, I'm suprised this compiles on macOS. I would expect to see
the following error.

  $ ./configure gl_cv_func_access_slash_works=no
  [...]
  In file included from b-grok.c:21:
  b-grok.c: In function ‘full’:
  base.h:320:24: error: ‘tiny_rpl_access’ undeclared (first use in this 
function); did you mean ‘tiny_access’?
    320 | #define TINY(x)       (tiny_ ## x)
        |                        ^~~~~
  b-grok.c:165:45: note: in expansion of macro ‘TINY’
    165 | #define SYNCH(g,kw)  must_read_keyword (g, &TINY (kw))
        |                                             ^~~~
  b-grok.c:583:3: note: in expansion of macro ‘SYNCH’
    583 |   SYNCH (g, access);
        |   ^~~~~
  base.h:320:24: note: each undeclared identifier is reported only once for 
each function it appears in
    320 | #define TINY(x)       (tiny_ ## x)
        |                        ^~~~~
  b-grok.c:165:45: note: in expansion of macro ‘TINY’
    165 | #define SYNCH(g,kw)  must_read_keyword (g, &TINY (kw))
        |                                             ^~~~
  b-grok.c:583:3: note: in expansion of macro ‘SYNCH’
    583 |   SYNCH (g, access);
        |   ^~~~~
  b-grok.c:584:14: error: ‘struct repo’ has no member named ‘rpl_access’; did 
you mean ‘access’?
    584 |   for (PREP (access); maybe_read_snippet (g); count++)
        |              ^~~~~~
  b-grok.c:565:50: note: in definition of macro ‘PREP’
    565 | #define PREP(field)  count = 0, box.next = repo->field, tp = &box
        |                                                  ^~~~~
  b-grok.c:586:9: error: ‘struct repo’ has no member named ‘rpl_access’; did 
you mean ‘access’?
    586 |   DONE (access);
        |         ^~~~~~
  b-grok.c:567:28: note: in definition of macro ‘DONE’
    567 | #define DONE(field)  repo->field = box.next, repo->field ## _count = 
count
        |                            ^~~~~
  make[2]: *** [Makefile:2111: b-grok.o] Error 1

In any case, any time the gnulib access replacement is used, the build
will fail.

I've attached a patch.

Collin

0001-rcs-Fix-build-failure-caused-by-Gnulib-s-access.patch
Description: Text Data