Re: RCS 5.10.1 fails 6 tests on 2023 Mac Studio with macOS 15.0 Sequoia

[Collin Funk]

Hi Paul,

Paul Eggert <eggert@cs.ucla.edu> writes:

> Thanks, I installed the attached patch. It's more elaborate than what
> you suggested, the upside being that we don't include <unistd.h> where
> it's not needed.

One minor issue with this patch. See the following lines in Gnulib's
stdlib.in.h:

#if (@GNULIB_MKSTEMP@ || @GNULIB_MKSTEMPS@ || @GNULIB_MKOSTEMP@ || 
@GNULIB_MKOSTEMPS@ || @GNULIB_GETSUBOPT@ || defined GNULIB_POSIXCHECK) && ! 
defined __GLIBC__ && !(defined _WIN32 && ! defined __CYGWIN__)
/* On Mac OS X 10.3, only <unistd.h> declares mkstemp.  */
/* On Mac OS X 10.5, only <unistd.h> declares mkstemps.  */
/* On Mac OS X 10.13, only <unistd.h> declares mkostemp and mkostemps.  */
/* On Cygwin 1.7.1, only <unistd.h> declares getsubopt.  */
/* But avoid namespace pollution on glibc systems and native Windows.  */
# include <unistd.h>
#endif

On non-glibc systems including stdlib.h will include unistd.h since rcs
uses mkstemp.

This causes a problem in src/rcs.c and src/rlog.c when something like
GROK (access) is used since rpl_access will be used.

I've attached a patch, but I'll let you decide if there is a more
elegant way to handle it. Perhaps the module can just be excluded.

Collin

0001-maint-Fix-more-undefined-references-caused-by-Gnulib.patch
Description: Text Data