bug-rcs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RCS 5.10.1 fails 6 tests on 2023 Mac Studio with macOS 15.0 Sequoia


From: Paul Eggert
Subject: Re: RCS 5.10.1 fails 6 tests on 2023 Mac Studio with macOS 15.0 Sequoia
Date: Thu, 26 Sep 2024 08:16:35 -0700
User-agent: Mozilla Thunderbird

Thanks for reporting that. It looks like the use of 'access' is more trouble than it's worth. I'd rather not have to chase down all the uses of 'access' that should stay 'access', vs be replaced by 'rpl_access'. I now see that RCS actually uses the 'access' function in one spot, too.

The 'access' function is trouble, as it inherently leads to races. It's also wrong for setuid programs; we could fix that by using faccessat instead but it's not worth the hassle to drag that in from Gnulib (and avoid the 'access' module).

I reverted my most recent patch, and installed the attached two patches instead. This should cause RCS to not pull in Gnulib's 'access' module, and not use the 'access' function.

Attachment: 0001-maint-Stop-using-findprog.patch
Description: Text Data

Attachment: 0002-maint-Stop-using-access.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]