Re: purpose and implementation of code reviews

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > == How to do code reviews?

  > The main implication is that commits from *all* developers should be
  > reviewed from now on. Not only of the more junior ones. Not only of those
  > developers who frequently make mistakes.

This would be the strongest form of that policy change, but also the
most costly in terms of aditional work required.  So I think we should
also consider less strict versions of this policy.

  > == Should the "Information for Maintainers of GNU Software" [2] mention
  >    code reviews as a good practice?

  > Should it mention code reviews as a recommended good practice?

  > Should it go into details?

I think it would be good to make clear and concrete recommendations.
But ther ecan be more than one option of policy that a package's
maintainers could choose to follow.




-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)