Re: exclude17.at and exclude18.at tests are missing in the tar-1.35 tarball

[Lukas Javorsky]

Hi Paul,

I'm not sure why it shouldn't be a problem when we run "./configure; make check"
It does fail as the testsuite doesn't find those two tests.

What I've done is that I've copied both of the files and added them to the package and it works just fine.

Do you think that there is any issue with that approach?

On Tue, Jul 18, 2023 at 6:39 PM Paul Eggert <eggert@cs.ucla.edu> wrote:

On 2023-07-18 07:03, Lukas Javorsky wrote:
> Tests `exclude17.at` and `exclude18.at` are missing in the tar-1.35 tarball
> [1] which causes the check phase to fail as it tries to execute missing
> tests.

This should not be a problem with the tar 1.35 tarball, as the files
should not be needed if you run "./configure; make check". However, it
can indeed be a problem if you modify source files before building. I
installed the attached patch to fix this.


On 2023-07-18 07:08, Adam Sampson wrote:
> (It would be a good idea to require "make distcheck" as part of the
> release process, which should catch this kind of problem.)

Yes it would, thanks.

--

S pozdravom/ Best regards

Lukáš Javorský

Software Engineer, Core service - Databases

Red Hat

Purkyňova 115 (TPB-C)

612 00 Brno - Královo Pole

ljavorsk@redhat.com