Re: makeinfo 4.7: buggy execute_string() calls

[Christian Schenk]

Alper Ersoy wrote:
> Hi Christian,
>
> Christian Schenk wrote:
>> There are some sleeping dogs in makeinfo/xml.c. For example, take a
>> look at function xml_insert_indexterm:
>>
>>         execute_string (indexterm);
>>
>> The format string argument ("%s") is missing.
>>
>
> I don't believe that's a bug.  indexterm is a string, and that's what
> execute_string expects.

Alper, please take a closer look at execute_string. The first argument
really is a printf format string. If you still don't believe, then please
try this

makeinfo --docbook dvips.texi

This produces a nice crash (Makeinfo compiled with MSVC, WinXP) because of
the indexterm '%*Font'.

> Of
> course, if there's a problem with it, it's very easy and harmless to
> converts that type of calls to execute_string ("%s", indexterm), etc.

Exactly :-)

Best,
Chrstian