[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: extra keys from XS parser not decoded?
From: |
Gavin Smith |
Subject: |
Re: extra keys from XS parser not decoded? |
Date: |
Fri, 25 Feb 2022 17:48:57 +0000 |
On Fri, Feb 25, 2022 at 11:20:58AM +0100, Patrice Dumas wrote:
> > I think you're right. Any time a string is created it should probably
> > have the UTF-8 flag set, unless it represents a filename.
>
> It is ok too, I think, if we know that it can only be ascii, like
> @-command names or type. I guess that there should be strings in indices
> structures too.
>
> If it represents a filename, there may be a need to recode to the
> encoding filenames are encoded to, as is done for @include file names.
I've done this for several places that strings were created in the XS
parser. It resolves the discrepancies that were in the test suite
at least.