Re: bug in texi2dvi, on Windows/Msys2 it cannot find tex

[Tomas Kalibera]

On 4/8/22 15:31, Gavin Smith wrote:
> On Fri, Apr 08, 2022 at 03:15:01PM +0200, Tomas Kalibera wrote:
> > > What happens if we don't set MSYSTEM at all?
> > >
> > > diff --git a/util/texi2dvi b/util/texi2dvi
> > > index 1f42b41907..c506bbad37 100755
> > > --- a/util/texi2dvi
> > > +++ b/util/texi2dvi
> > > @@ -85,7 +85,7 @@ IFS="$space$tab$newline"
> > >    # Msys. It is safer to use OSTYPE, this is why we set MSYSTEM to
> > >    # $OSTYPE before calling uname
> > >    if test -n "$COMSPEC$ComSpec" \
> > > -   && MSYSTEM=$OSTYPE uname | $EGREP -iv 'cygwin|msys' >/dev/null; then
> > > +   && uname | $EGREP -iv 'cygwin|msys' >/dev/null; then
> > >      path_sep=";"
> > >    else
> > >      path_sep=":"
> > It works with Msys2 and cygwin for me, but breaks with MSYSTEM, where
> What is MSYSTEM?  Is this the original msys?
>
> > $ uname
> > MINGW32_NT-6.2
> >
> > $ MSYSTEM=$OSTYPE uname
> > msys_NT-6.2
> >
> > $ uname -a
> > MINGW32_NT-6.2 DESKTOP-G858KME 1.0.19(0.48/3/2) 2016-07-13 17:45 i686 Msys
> Does the path separator need to be set to ; on this system?  Is anybody
> likely to be running texi2dvi from it?
>
> Are you sure that MSYSTEM is set up correctly?  Is the MSYSTEM envvar
> set to something else, or just not set at all?

This is a completely clean installation using mingw-get which I 
downloaded from https://sourceforge.net/projects/mingw/files/Installer/, 
without any manual configuration. I've also installed a clean 
installation of cygwin, for the same reason. Normally I use Msys2.

Would this be an acceptable fix? (turn OSTYPE to uppercase when setting 
MSYSTEM)

   MSYSTEM=$(echo $OSTYPE | tr [a-z] [A-Z]) uname | $EGREP -iv 
'cygwin|msys' >/dev/null; then

It was suggested by Markus Mützel in a downstream discussion (Msys2) and 
it works for me in Msys2, cygwin and the installation I described which 
I believe is what MSYSTEM refers to in texi2dvi source (but I am not 
sure). On all these systems, the path separator needs to be ":".

The downstream discussion with some more detail is here: 
https://github.com/msys2/MSYS2-packages/issues/2901

Thanks
Tomas