Re: makeinfo no longer validates the menu structure

[Patrice Dumas]

On Thu, Jun 22, 2023 at 04:32:59PM +0200, Bruno Haible wrote:
> Hi,
> 
> $ env CHECK_NORMAL_MENU_STRUCTURE=1 LANG= LC_MESSAGES= LC_ALL= LANGUAGE= 
> makeinfo --no-split --reference-limit=2000 gnulib.texi
> (Still no warning, no error.)

It is on purpose that CHECK_NORMAL_MENU_STRUCTURE is needed, because
with manually made menus and node directions, it is .  Setting
customization variable is not done with environment variables but with
the -c option.  With that option, for your reproducer, I get (with the
texinfo git head version):

~/tmp/gnulib/doc((HEAD detached at 458694e417))$ env LANG= LC_MESSAGES= LC_ALL= 
LANGUAGE= ~/src/texinfo/tp/texi2any.pl -c CHECK_NORMAL_MENU_STRUCTURE=1  
--no-split --reference-limit=2000 gnulib.texi
strings.texi:208: warning: node next pointer for `Strings with NUL characters' 
is `String Functions in C Locale' but next is `Comparison of string APIs' in 
menu
strings.texi:21: warning: node `Strings' lacks menu item for `String Functions 
in C Locale' despite being its Up target
strings.texi:233: warning: node prev pointer for `Comparison of string APIs' is 
`String Functions in C Locale' but prev is `Strings with NUL characters' in menu


It is not the same as what was produced previously that you show below.
The code corresponding to those messages still exist, but, if I recall
well, we removed some waranings for nodes with manual directions, as we
cnosidered that it could be valid constructs.

> Result with makeinfo 6.4 ... 6.7:
> 
> ./strings.texi:208: warning: node next `Strings with NUL characters' in menu 
> `Comparison of string APIs' and in sectioning `String Functions in C Locale' 
> differ
> ./c-locale.texi:1: warning: node `Comparison of string APIs' is next for 
> `String Functions in C Locale' in sectioning but not in menu
> ./c-locale.texi:1: warning: node `Strings with NUL characters' is prev for 
> `String Functions in C Locale' in sectioning but not in menu
> ./c-locale.texi:1: warning: node `Strings' is up for `String Functions in C 
> Locale' in sectioning but not in menu
> ./strings.texi:21: node `Strings' lacks menu item for `String Functions in C 
> Locale' despite being its Up target
> ./strings.texi:233: warning: node prev `Comparison of string APIs' in menu 
> `Strings with NUL characters' and in sectioning `String Functions in C 
> Locale' differ


-- 
Pat