RE: [Bug-wget] wget 1.11.4 on Interix (strcasecmp needs _ALL_SOURCE)

[Jay]

The strtoll error can be addressed by a more conservative patch to ftp.c:
 
 
#if defined(__INTERIX) && !defined(_ALL_SOURCE)
#define _ALL_SOURCE
#include "strings.h"    should be angle brackets but Hotmail usually mangles 
the line.
#undef _ALL_SOURCE
#endif


instead of just:
 
 
#if defined(__INTERIX) && !defined(_ALL_SOURCE)
#define _ALL_SOURCE
#endif
 
 
"I'm not sure what changed", ok, well, a big change is I did install that big 
wad
of interopsystems stuff. I /ought/ not be relevant, but it easily could be.
I got somewhat sick of compiling stuff and wanted to move along a little faster.
 

 - Jay


----------------------------------------
> From: address@hidden
> To: address@hidden
> CC: address@hidden
> Subject: RE: [Bug-wget] wget 1.11.4 on Interix (strcasecmp needs _ALL_SOURCE)
> Date: Mon, 22 Jun 2009 13:38:06 +0000
>
>
> Micah, in the 1.11.4 code, at your suggestion, I tried two forms of changing 
> sysdep.h instead of ftp.c and they both failed.
>
>
> I have since found that a perhaps "popular" patch to the system does put 
> _ALL_SOURCE in $CFLAGS.
> The patch is installing the bundle of stuff from www.interopsystems.com.
> I'm not sure if you can/should just rest on that and be done or not.
>
>
> I'm also now getting:
>
>
> In file included from /src/wget-1.11.4/src/ftp.c:47:
> /src/wget-1.11.4/src/wget.h:191: error: parse error before '(' token
> /src/wget-1.11.4/src/wget.h:191: error: parse error before "char"
> gmake[1]: *** [ftp.o] Error 1
> gmake[1]: Leaving directory `/dev/fs/C/obj/wget/src'
> gmake: *** [src] Error 2
> bash-3.2$ gmake
>
>
> strtoll_type strtoll (const char *, char **, int);
>
>
> - Jay
>
>
> ----------------------------------------
>> Date: Sat, 20 Jun 2009 14:28:31 -0700
>> From: address@hidden
>> To: address@hidden
>> CC: address@hidden
>> Subject: Re: [Bug-wget] wget 1.11.4 on Interix (strcasecmp needs _ALL_SOURCE)
>>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Jay wrote:
>>> gcc -I. -I/src/wget-1.11.4/src -DHAVE_CONFIG_H 
>>> -DSYSTEM_WGETRC=\"/usr/etc/wget
>>> rc\" -DLOCALEDIR=\"/usr/share/locale\" -O2 -Wall -c 
>>> /src/wget-1.11.4/src/ftp.c
>>> /src/wget-1.11.4/src/ftp.c: In function `ftp_expected_bytes':
>>> /src/wget-1.11.4/src/ftp.c:98: warning: implicit declaration of function 
>>> `strncasecmp'
>>> /src/wget-1.11.4/src/ftp.c: In function `ftp_retrieve_list':
>>> /src/wget-1.11.4/src/ftp.c:1487: warning: implicit declaration of function 
>>> `readlink'
>>> /src/wget-1.11.4/src/ftp.c:1503: warning: implicit declaration of function 
>>> `symlink'
>>> /src/wget-1.11.4/src/ftp.c: In function `ftp_retrieve_glob':
>>> /src/wget-1.11.4/src/ftp.c:1756: error: `strcasecmp' undeclared (first use 
>>> in this function)
>>> /src/wget-1.11.4/src/ftp.c:1756: error: (Each undeclared identifier is 
>>> reportedonly once
>>> /src/wget-1.11.4/src/ftp.c:1756: error: for each function it appears in.)
>>>
>>>
>>> There were doubts raised as to if this is sufficient.
>>> It is sufficient.
>>
>>
>> Good to hear.
>>
>> How does this version do? (It applies it to sysdep.h, rather than
>> ftp.c.) I'm thinking it might possibly even help with the implicit
>> declaration complaints?
>>
>> ...oh... I just realized though, that you probably can't apply this
>> cleanly to wget-1.11.4, because the context is different in that
>> sysdep.h. You could try to apply it by hand by yourself, though... just
>> put it below the inclusion-guards for sysdep.h.
>>
>> Or you could try it with the latest development sources (pre-1.12). But
>> using those can be a bit more work, since they don't include the
>> configure script, and have more dependencies. (If you feel like doing
>> that anyway, just see http://wget.addictivecode.org/RepositoryAccess).
>>
>> diff -r 61e811876926 src/sysdep.h
>> - --- a/src/sysdep.h Mon Jun 15 23:48:14 2009 -0700
>> +++ b/src/sysdep.h Sat Jun 20 14:23:41 2009 -0700
>> @@ -41,6 +41,10 @@
>> # endif
>> #endif
>>
>> +#if defined(__INTERIX) && !defined(_ALL_SOURCE)
>> +# define _ALL_SOURCE
>> +#endif
>> +
>> /* The "namespace tweaks" below attempt to set a friendly "compilation
>> environment" under popular operating systems. Default compilation
>> environment often means that some functions that are "extensions"
>>
>>
>> - --
>> Micah J. Cowan
>> Programmer, musician, typesetting enthusiast, gamer.
>> Maintainer of GNU Wget and GNU Teseq
>> http://micah.cowan.name/
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.9 (GNU/Linux)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>>
>> iEYEARECAAYFAko9VH8ACgkQ7M8hyUobTrG3/QCfStUqAwaYhUq0HBWaIV+Ko113
>> 2+0An2aIIVteVAzmH7K11+dNlujzr9WK
>> =Rv99
>> -----END PGP SIGNATURE-----